webapps: initial addition of splash screen icon downloading

chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
index b6fa211a2a05022efd039efa26b381a6f5aef463..b6364512ca7a966bba11ad0f6d4d912bac4955b2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
@@ -5,6 +5,7 @@
 package org.chromium.chrome.browser.banners;
 
 import android.content.Context;
+import android.content.res.Resources;
 import android.text.TextUtils;
 
 import org.chromium.base.ApplicationStatus;
@@ -70,11 +71,16 @@ public class AppBannerManager extends EmptyTabObserver {
      * @param tab Tab that the AppBannerManager will be attached to.
      */
     public AppBannerManager(Tab tab, Context context) {
-        int iconSizePx = context.getResources().getDimensionPixelSize(R.dimen.app_banner_icon_size);
-        float density = context.getResources().getDisplayMetrics().density;
-        int iconSizeDp = (int) (iconSizePx / density);
+        Resources resources = context.getResources();
 
-        mNativePointer = nativeInit(iconSizeDp);
+        int splashIconPx = resources.getDimensionPixelSize(R.dimen.webapp_splash_icon_size);

[gone, 2015/08/26 02:01:19]

We should consider calling these splash images instead of splash icons; it'll
get confusing with the launcher/recents icon.  If these images get defined as a
separate manifest tag, devs might want to use a different image than their
launcher icon.  I think "splash images" are the more common nomenclature,
anyway.  

[Lalit Maganti, 2015/08/26 13:11:56]

I like the name so I have globally (C++ and Java in this patch) renamed it to be
splashImage.

+        int iconSizePx = resources.getDimensionPixelSize(R.dimen.app_banner_icon_size);
+        float density = resources.getDisplayMetrics().density;
+
+        int splashIconDp = (int) (splashIconPx / density);
+        int iconDp = (int) (iconSizePx / density);
+
+        mNativePointer = nativeInit(splashIconDp, iconDp);
         mTab = tab;
         updatePointers();
     }
@@ -169,7 +175,7 @@ public class AppBannerManager extends EmptyTabObserver {
     }
 
     private static native boolean nativeIsEnabled();
-    private native long nativeInit(int iconSize);
+    private native long nativeInit(int splashIconSize, int iconSize);

[gone, 2015/08/26 02:01:19]

splashImageDp, iconDp

[Lalit Maganti, 2015/08/26 13:11:56]

Added ideal as a prefix and the word "in" as well to make it consistent and
clear across C++ and Java.

     private native void nativeDestroy(long nativeAppBannerManagerAndroid);
     private native void nativeReplaceWebContents(long nativeAppBannerManagerAndroid,
             WebContents webContents);