chrome/test/data/banners/manifest.json - Issue 1310223002: webapps: initial addition of splash screen icon downloading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/banners/manifest.json

Issue 1310223002: webapps: initial addition of splash screen icon downloading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-database-exp

Patch Set: Rebase on registry patch and add register call Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/shortcut_helper.cc ('K') | « chrome/browser/banners/app_banner_manager.cc ('k') | chrome/test/data/banners/splash-image.png » ('j') | chrome/test/data/webapps/manifest.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/banners/manifest.json

diff --git a/chrome/test/data/banners/manifest.json b/chrome/test/data/banners/manifest.json

index 89429dc9057aef9204ef5b36a943692cfa2577c4..1ea86a3643a21cd91ebce14673bddce56b70282b 100644

--- a/chrome/test/data/banners/manifest.json

+++ b/chrome/test/data/banners/manifest.json

@@ -25,6 +25,11 @@

"src": "launcher-icon-4x.png",

"sizes": "192x192",

"type": "image/png"

+ },

+ {

+ "src": "splash-image.png",

mlamouri (slow - plz ping) 2015/09/02 16:56:58 nit: I really don't like these names because nothi

Lalit Maganti 2015/09/02 17:15:42 Done.

+ "sizes": "512x512",

+ "type": "image/png"

}

"start_url": "manifest_test_page.html",