chrome/test/data/banners/manifest.json - Issue 1310223002: webapps: initial addition of splash screen icon downloading

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/banners/manifest.json

Issue 1310223002: webapps: initial addition of splash screen icon downloading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-database-exp

Patch Set: Rebase on registry patch and add register call Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/android/shortcut_helper.cc ('K') | « chrome/browser/banners/app_banner_manager.cc ('k') | chrome/test/data/banners/splash-image.png » ('j') | chrome/test/data/webapps/manifest.json » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "name": "Manifest test app",	2 "name": "Manifest test app",

3 "icons": [	3 "icons": [

4 {	4 {

5 "src": "launcher-icon-1x.png",	5 "src": "launcher-icon-1x.png",

6 "sizes": "48x48",	6 "sizes": "48x48",

7 "type": "image/png"	7 "type": "image/png"

8 },	8 },

9 {	9 {

10 "src": "launcher-icon-1-5x.png",	10 "src": "launcher-icon-1-5x.png",

11 "sizes": "72x72",	11 "sizes": "72x72",

12 "type": "image/png"	12 "type": "image/png"

13 },	13 },

14 {	14 {

15 "src": "launcher-icon-2x.png",	15 "src": "launcher-icon-2x.png",

16 "sizes": "96x96",	16 "sizes": "96x96",

17 "type": "image/png"	17 "type": "image/png"

18 },	18 },

19 {	19 {

20 "src": "launcher-icon-3x.png",	20 "src": "launcher-icon-3x.png",

21 "sizes": "144x144",	21 "sizes": "144x144",

22 "type": "image/png"	22 "type": "image/png"

23 },	23 },

24 {	24 {

25 "src": "launcher-icon-4x.png",	25 "src": "launcher-icon-4x.png",

26 "sizes": "192x192",	26 "sizes": "192x192",

27 "type": "image/png"	27 "type": "image/png"

	28 },

	29 {

	30 "src": "splash-image.png",
	mlamouri (slow - plz ping) 2015/09/02 16:56:58 nit: I really don't like these names because nothi nit: I really don't like these names because nothing forbids us from havin "launcher-icon-" to be used for the splashscreen or "splash-image.png" to be used as a launcher icon (in a 10x device :)). Could you just name it image-512px.png ? Lalit Maganti* 2015/09/02 17:15:42 Done. Show quoted text On 2015/09/02 16:56:58, Mounir Lamouri wrote: > nit: I really don't like these names because nothing forbids us from havin > "launcher-icon-*" to be used for the splashscreen or "splash-image.png" to be > used as a launcher icon (in a 10x device :)). > > Could you just name it image-512px.png ? Done.
	31 "sizes": "512x512",

	32 "type": "image/png"

28 }	33 }

29 ],	34 ],

30 "start_url": "manifest_test_page.html",	35 "start_url": "manifest_test_page.html",

31 "display": "standalone",	36 "display": "standalone",

32 "orientation": "landscape"	37 "orientation": "landscape"

33 }	38 }

OLD	NEW