webapps: initial addition of splash screen icon downloading

chrome/browser/android/banners/app_banner_infobar_delegate_android.h

Index: chrome/browser/android/banners/app_banner_infobar_delegate_android.h
diff --git a/chrome/browser/android/banners/app_banner_infobar_delegate_android.h b/chrome/browser/android/banners/app_banner_infobar_delegate_android.h
index 52c77c1166e29f50679ad5ce4dc132a2dfb40c56..c7efe60b346dbdd198f23d1903285eb4fb247537 100644
--- a/chrome/browser/android/banners/app_banner_infobar_delegate_android.h
+++ b/chrome/browser/android/banners/app_banner_infobar_delegate_android.h
@@ -7,6 +7,7 @@
 
 #include "base/android/scoped_java_ref.h"
 #include "base/strings/string16.h"
+#include "chrome/browser/android/banners/app_banner_data_fetcher_android.h"
 #include "components/infobars/core/confirm_infobar_delegate.h"
 #include "content/public/common/manifest.h"
 #include "ui/gfx/image/image.h"
@@ -30,6 +31,7 @@ class AppBannerInfoBarDelegateAndroid : public ConfirmInfoBarDelegate {
   // Delegate for promoting a web app.
   AppBannerInfoBarDelegateAndroid(
       int event_request_id,
+      scoped_refptr<AppBannerDataFetcherAndroid> data_fetcher,
       const base::string16& app_title,
       SkBitmap* app_icon,
       const content::Manifest& web_app_data);
@@ -74,10 +76,14 @@ class AppBannerInfoBarDelegateAndroid : public ConfirmInfoBarDelegate {
 
   base::android::ScopedJavaGlobalRef<jobject> java_delegate_;
 
+  int event_request_id_;

[gone, 2015/08/27 18:00:29]

why'd this get moved up?

[Lalit Maganti, 2015/08/27 18:57:14]

To make it consistent with the ordering in the constructor/initializer list.
Otherwise the compiler complains that the variables are being initialized in the
wrong order.

[gone, 2015/08/27 19:06:05]

Rephrasing then: why did put data_fetcher_ in the order you did in the
initializer list?  That forces this to be reordered.

[Lalit Maganti, 2015/08/27 19:16:40]

Hmm that's a fair point. It's just adding noise to this commit I guess so I can
switch it back.

[Lalit Maganti, 2015/09/01 15:33:08]

Done.

+
+  // Used to fetch the splash screen icon for webapps.
+  scoped_refptr<AppBannerDataFetcherAndroid> data_fetcher_;
+
   base::string16 app_title_;
   scoped_ptr<SkBitmap> app_icon_;
 
-  int event_request_id_;
   content::Manifest web_app_data_;
 
   base::android::ScopedJavaGlobalRef<jobject> native_app_data_;