webapps: initial addition of splash screen icon downloading

chrome/browser/android/banners/app_banner_infobar_delegate_android.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_INFOBAR_DELEGATE_ANDROID_H_
 #define CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_INFOBAR_DELEGATE_ANDROID_H_
 
 #include "base/android/scoped_java_ref.h"
 #include "base/strings/string16.h"
+#include "chrome/browser/android/banners/app_banner_data_fetcher_android.h"
 #include "components/infobars/core/confirm_infobar_delegate.h"
 #include "content/public/common/manifest.h"
 #include "ui/gfx/image/image.h"
 #include "url/gurl.h"
 
 namespace content {
 class WebContents;
 }
 
 namespace infobars {
 class InfoBarManager;
 }  // namespace infobars
 
 class AppBannerInfoBar;
 
 namespace banners {
 
 // Manages installation of an app being promoted by a webpage.
 class AppBannerInfoBarDelegateAndroid : public ConfirmInfoBarDelegate {
  public:
   // Delegate for promoting a web app.
   AppBannerInfoBarDelegateAndroid(
       int event_request_id,
+      scoped_refptr<AppBannerDataFetcherAndroid> data_fetcher,
       const base::string16& app_title,
       SkBitmap* app_icon,
       const content::Manifest& web_app_data);
 
   // Delegate for promoting an Android app.
   AppBannerInfoBarDelegateAndroid(
       int event_request_id,
       const base::string16& app_title,
       SkBitmap* app_icon,
       const base::android::ScopedJavaGlobalRef<jobject>& native_app_data,
@@ skipping 24 matching lines @@
   // ConfirmInfoBarDelegate:
   gfx::Image GetIcon() const override;
   void InfoBarDismissed() override;
   base::string16 GetMessageText() const override;
   int GetButtons() const override;
   bool Accept() override;
   bool LinkClicked(WindowOpenDisposition disposition) override;
 
   base::android::ScopedJavaGlobalRef<jobject> java_delegate_;
 
+  int event_request_id_;

[gone, 2015/08/27 18:00:29]

why'd this get moved up?

[Lalit Maganti, 2015/08/27 18:57:14]

To make it consistent with the ordering in the constructor/initializer list.
Otherwise the compiler complains that the variables are being initialized in the
wrong order.

[gone, 2015/08/27 19:06:05]

Rephrasing then: why did put data_fetcher_ in the order you did in the
initializer list?  That forces this to be reordered.

[Lalit Maganti, 2015/08/27 19:16:40]

Hmm that's a fair point. It's just adding noise to this commit I guess so I can
switch it back.

[Lalit Maganti, 2015/09/01 15:33:08]

Done.

+
+  // Used to fetch the splash screen icon for webapps.
+  scoped_refptr<AppBannerDataFetcherAndroid> data_fetcher_;
+
   base::string16 app_title_;
   scoped_ptr<SkBitmap> app_icon_;
 
-  int event_request_id_;
   content::Manifest web_app_data_;
 
   base::android::ScopedJavaGlobalRef<jobject> native_app_data_;
   std::string native_app_package_;
   std::string referrer_;
   bool has_user_interaction_;
 
   DISALLOW_COPY_AND_ASSIGN(AppBannerInfoBarDelegateAndroid);
 };  // AppBannerInfoBarDelegateAndroid
 
 // Register native methods.
 bool RegisterAppBannerInfoBarDelegateAndroid(JNIEnv* env);
 
 }  // namespace banners
 
 #endif  // CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_INFOBAR_DELEGATE_ANDROID_H_