Remove use of JSONReader::DeprecatedRead from chrome/test

Remove use of JSONReader::DeprecatedRead from chrome/test

Remove use of deprecated function DeprecatedRead from chrome/test

BUG=523194
Committed: https://crrev.com/1a13a39982f7ca1fff45691de781ffff46e16e07
Cr-Commit-Position: refs/heads/master@{#352544}

[Olli Raula, 2015-09-09 07:25:09]

olli.raula@intel.com changed reviewers:
+ sky@chromium.org

[Olli Raula, 2015-09-09 07:25:22]

Could you review?

[Olli Raula, 2015-09-09 13:33:44]

If that fix is not needed, I can use the first version. Otherwise not need to
review yet. https://codereview.chromium.org/1328233002/

[Olli Raula, 2015-09-09 13:33:52]

If that fix is not needed, I can use the first version. Otherwise not need to
review yet. https://codereview.chromium.org/1328233002/

[Olli Raula, 2015-09-09 14:30:05]

Should be fine now

[sky, 2015-09-09 16:03:04]

https://codereview.chromium.org/1310173010/diff/40001/chrome/test/chromedrive...
File chrome/test/chromedriver/chrome/dom_tracker_unittest.cc (right):

https://codereview.chromium.org/1310173010/diff/40001/chrome/test/chromedrive...
chrome/test/chromedriver/chrome/dom_tracker_unittest.cc:63: params.Set("nodes",
base::JSONReader::Read(nodes).release());
I think you should make DictionaryValue::Set take a scoped_ptr and then do this
change.

https://codereview.chromium.org/1310173010/diff/40001/chrome/test/remoting/re...
File chrome/test/remoting/remote_desktop_browsertest.cc (right):

https://codereview.chromium.org/1310173010/diff/40001/chrome/test/remoting/re...
chrome/test/remoting/remote_desktop_browsertest.cc:867:
ignore_result(root.release());
Where does root get destroyed?

[Olli Raula, 2015-10-01 13:26:57]

Thanks for review, now fixed

[sky, 2015-10-02 15:47:35]

https://codereview.chromium.org/1310173010/diff/60001/chrome/test/remoting/re...
File chrome/test/remoting/remote_desktop_browsertest.cc (right):

https://codereview.chromium.org/1310173010/diff/60001/chrome/test/remoting/re...
chrome/test/remoting/remote_desktop_browsertest.cc:866: ASSERT_FALSE(root.get()
&& root->GetAsDictionary(&root_dict));
Why is this changing to ASSERT_FALSE?

[Olli Raula, 2015-10-05 08:04:43]

> Why is this changing to ASSERT_FALSE?

My mistake, now fixed.

[sky, 2015-10-05 15:59:35]

LGTM

[Olli Raula, 2015-10-06 05:50:58]

The CQ bit was checked by olli.raula@intel.com

[commit-bot: I haz the power, 2015-10-06 05:51:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1310173010/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1310173010/80001

[commit-bot: I haz the power, 2015-10-06 05:55:42]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-10-06 05:56:37]

Patchset 5 (id:??) landed as
https://crrev.com/1a13a39982f7ca1fff45691de781ffff46e16e07
Cr-Commit-Position: refs/heads/master@{#352544}