Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: chrome/test/chromedriver/chrome/dom_tracker_unittest.cc

Issue 1310173010: Remove use of JSONReader::DeprecatedRead from chrome/test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/chromedriver/chrome/frame_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/dom_tracker_unittest.cc
diff --git a/chrome/test/chromedriver/chrome/dom_tracker_unittest.cc b/chrome/test/chromedriver/chrome/dom_tracker_unittest.cc
index 4ba6dea9063ff6ace7980b1e68e3238c28c69f8e..34a37f5a929eac4a3ed2651d8f68f236163b9d27 100644
--- a/chrome/test/chromedriver/chrome/dom_tracker_unittest.cc
+++ b/chrome/test/chromedriver/chrome/dom_tracker_unittest.cc
@@ -60,7 +60,7 @@ TEST(DomTracker, GetFrameIdForNode) {
" {\"nodeId\":102,\"frameId\":\"f\"}]"
"}]";
base::DictionaryValue params;
- params.Set("nodes", base::JSONReader::DeprecatedRead(nodes));
+ params.Set("nodes", base::JSONReader::Read(nodes));
ASSERT_EQ(kOk, tracker.OnEvent(&client, "DOM.setChildNodes", params).code());
ASSERT_TRUE(tracker.GetFrameIdForNode(101, &frame_id).IsError());
ASSERT_TRUE(frame_id.empty());
@@ -79,15 +79,15 @@ TEST(DomTracker, ChildNodeInserted) {
std::string frame_id;
base::DictionaryValue params;
- params.Set("node", base::JSONReader::DeprecatedRead("{\"nodeId\":1}"));
+ params.Set("node", base::JSONReader::Read("{\"nodeId\":1}"));
ASSERT_EQ(kOk,
tracker.OnEvent(&client, "DOM.childNodeInserted", params).code());
ASSERT_TRUE(tracker.GetFrameIdForNode(1, &frame_id).IsError());
ASSERT_TRUE(frame_id.empty());
params.Clear();
- params.Set("node", base::JSONReader::DeprecatedRead(
- "{\"nodeId\":2,\"frameId\":\"f\"}"));
+ params.Set("node",
+ base::JSONReader::Read("{\"nodeId\":2,\"frameId\":\"f\"}"));
ASSERT_EQ(kOk,
tracker.OnEvent(&client, "DOM.childNodeInserted", params).code());
ASSERT_TRUE(tracker.GetFrameIdForNode(2, &frame_id).IsOk());
« no previous file with comments | « no previous file | chrome/test/chromedriver/chrome/frame_tracker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698