Issue 1310153004: Off by one in XSSAuditor::canonicalizedSnippetForJavaScript()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1310153004: Off by one in XSSAuditor::canonicalizedSnippetForJavaScript() (Closed)

Created:
5 years, 3 months ago by Tom Sepez

Modified:
5 years, 3 months ago

Reviewers:
Mike West

CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, kinuko+watch

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Off by one in XSSAuditor::canonicalizedSnippetForJavaScript() See discussion in bug. BUG=526104 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201803

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -2 lines)			Patch
A +	LayoutTests/http/tests/security/xssAuditor/script-tag-with-trailing-script-and-urlencode.html	View	1 chunk	+1 line, -1 line	0 comments	Download
A	LayoutTests/http/tests/security/xssAuditor/script-tag-with-trailing-script-and-urlencode-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/html/parser/XSSAuditor.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310153004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310153004/1

5 years, 3 months ago (2015-09-04 16:23:44 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-09-04 16:50:40 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201803

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages