Source/core/html/parser/XSSAuditor.cpp - Issue 1310153004: Off by one in XSSAuditor::canonicalizedSnippetForJavaScript()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/parser/XSSAuditor.cpp

Issue 1310153004: Off by one in XSSAuditor::canonicalizedSnippetForJavaScript() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/parser/XSSAuditor.cpp

diff --git a/Source/core/html/parser/XSSAuditor.cpp b/Source/core/html/parser/XSSAuditor.cpp

index 57cab49a140d85313d3dcec702ff0b22b5468738..8b859f33c05858aaff2e094fc4df741de4420749 100644

--- a/Source/core/html/parser/XSSAuditor.cpp

+++ b/Source/core/html/parser/XSSAuditor.cpp

@@ -767,7 +767,7 @@ String XSSAuditor::canonicalizedSnippetForJavaScript(const FilterTokenRequest& r

break;

if (lastNonSpacePosition != kNotFound && startsOpeningScriptTagAt(string, foundPosition)) {

- foundPosition = lastNonSpacePosition;

+ foundPosition = lastNonSpacePosition + 1;

break;

}

if (foundPosition > startPosition + kMaximumFragmentLengthTarget) {