Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: Source/bindings/tests/idls/TestInterfaceInheritsNode.idl

Issue 131013002: IDL compiler: EventHandler attributes in Node interfaces (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix typo Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/idls/TestInterfaceInheritsNode.idl
diff --git a/Source/bindings/tests/idls/TestInterfaceCustomConstructor.idl b/Source/bindings/tests/idls/TestInterfaceInheritsNode.idl
similarity index 79%
copy from Source/bindings/tests/idls/TestInterfaceCustomConstructor.idl
copy to Source/bindings/tests/idls/TestInterfaceInheritsNode.idl
index dba8b7a3c9f8bb54e7210e0b6220e47341426cf5..264b8c7a8d460d495719a70cc3c2e214f4d6d5d1 100644
--- a/Source/bindings/tests/idls/TestInterfaceCustomConstructor.idl
+++ b/Source/bindings/tests/idls/TestInterfaceInheritsNode.idl
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2013 Google Inc. All rights reserved.
+ * Copyright (C) 2014 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
@@ -29,8 +29,10 @@
*/
[
- CustomConstructor,
- CustomConstructor(TestInterfaceEmpty testInterfaceEmptyArg),
- CustomConstructor(double doubleArg, optional double optionalDoubleArg),
-] interface TestInterfaceCustomConstructor {
+ DependentLifetime, // FIXME: should inherit from Node
haraken 2014/01/09 07:45:00 Why is this FIXME? Doesn't the inheritance work?
Nils Barth (inactive) 2014/01/09 07:49:11 I haven't yet implemented inheriting Extended Attr
haraken 2014/01/09 07:50:37 Makes sense. Thanks for the clarification.
+] interface TestInterfaceInheritsNode : Node {
+ attribute DOMString stringAttribute;
+ attribute EventHandler eventHandlerAttribute;
+ // [Reflect] attribute DOMString reflectStringAttribute;
+ // [Reflect, URL] attribute DOMString reflectUrlStringAttribute;
};

Powered by Google App Engine
This is Rietveld 408576698