Issue 131003007: Re-enable syncing shared settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131003007: Re-enable syncing shared settings. (Closed)

Created:
6 years, 10 months ago by Bernhard Bauer

Modified:
6 years, 10 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Re-enable syncing shared settings. BUG=316168 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247818

Patch Set 2 : review #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -8 lines)			Patch
	M	chrome/browser/sync/profile_sync_components_factory_impl.cc	View		1 chunk	+3 lines, -5 lines	0 comments	Download
	M	chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

LGTM if the server can handle it. https://codereview.chromium.org/131003007/diff/1/chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc File chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc (right): https://codereview.chromium.org/131003007/diff/1/chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc#newcode64 chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc:64: return datatypes; ...

6 years, 10 months ago (2014-01-29 14:53:10 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/131003007/10001

6 years, 10 months ago (2014-01-29 16:45:29 UTC) #3

Message was sent while issue was closed.

Change committed as 247818

Expand Messages | Collapse Messages

Issue 131003007: Re-enable syncing shared settings. (Closed)

Description

Patch Set 1 #

Patch Set 2 : review #

Messages