Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: chrome/browser/sync/profile_sync_components_factory_impl.cc

Issue 131003007: Re-enable syncing shared settings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "build/build_config.h" 6 #include "build/build_config.h"
7 #include "chrome/browser/about_flags.h" 7 #include "chrome/browser/about_flags.h"
8 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 8 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
9 #include "chrome/browser/bookmarks/enhanced_bookmarks_features.h" 9 #include "chrome/browser/bookmarks/enhanced_bookmarks_features.h"
10 #include "chrome/browser/browser_process.h" 10 #include "chrome/browser/browser_process.h"
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 #if defined(ENABLE_MANAGED_USERS) 227 #if defined(ENABLE_MANAGED_USERS)
228 if (profile_->IsManaged()) { 228 if (profile_->IsManaged()) {
229 pss->RegisterDataTypeController( 229 pss->RegisterDataTypeController(
230 new UIDataTypeController( 230 new UIDataTypeController(
231 syncer::MANAGED_USER_SETTINGS, this, profile_, pss)); 231 syncer::MANAGED_USER_SETTINGS, this, profile_, pss));
232 } else { 232 } else {
233 pss->RegisterDataTypeController( 233 pss->RegisterDataTypeController(
234 new UIDataTypeController( 234 new UIDataTypeController(
235 syncer::MANAGED_USERS, this, profile_, pss)); 235 syncer::MANAGED_USERS, this, profile_, pss));
236 } 236 }
237 // TODO(bauerb): Enable once the Sync server has been updated to know about 237 pss->RegisterDataTypeController(
238 // this data type. 238 new UIDataTypeController(
239 // pss->RegisterDataTypeController( 239 syncer::MANAGED_USER_SHARED_SETTINGS, this, profile_, pss));
240 // new UIDataTypeController(
241 // syncer::MANAGED_USER_SHARED_SETTINGS, this, profile_, pss));
242 #endif 240 #endif
243 } 241 }
244 242
245 void ProfileSyncComponentsFactoryImpl::RegisterDesktopDataTypes( 243 void ProfileSyncComponentsFactoryImpl::RegisterDesktopDataTypes(
246 ProfileSyncService* pss) { 244 ProfileSyncService* pss) {
247 // App sync is enabled by default. Register unless explicitly 245 // App sync is enabled by default. Register unless explicitly
248 // disabled. 246 // disabled.
249 if (!command_line_->HasSwitch(switches::kDisableSyncApps)) { 247 if (!command_line_->HasSwitch(switches::kDisableSyncApps)) {
250 pss->RegisterDataTypeController( 248 pss->RegisterDataTypeController(
251 new ExtensionDataTypeController(syncer::APPS, this, profile_, pss)); 249 new ExtensionDataTypeController(syncer::APPS, this, profile_, pss));
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
535 ProfileSyncComponentsFactory::SyncComponents 533 ProfileSyncComponentsFactory::SyncComponents
536 ProfileSyncComponentsFactoryImpl::CreateSessionSyncComponents( 534 ProfileSyncComponentsFactoryImpl::CreateSessionSyncComponents(
537 ProfileSyncService* profile_sync_service, 535 ProfileSyncService* profile_sync_service,
538 DataTypeErrorHandler* error_handler) { 536 DataTypeErrorHandler* error_handler) {
539 SessionModelAssociator* model_associator = 537 SessionModelAssociator* model_associator =
540 new SessionModelAssociator(profile_sync_service, error_handler); 538 new SessionModelAssociator(profile_sync_service, error_handler);
541 SessionChangeProcessor* change_processor = 539 SessionChangeProcessor* change_processor =
542 new SessionChangeProcessor(error_handler, model_associator); 540 new SessionChangeProcessor(error_handler, model_associator);
543 return SyncComponents(model_associator, change_processor); 541 return SyncComponents(model_associator, change_processor);
544 } 542 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698