Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 1309903005: Use correct template parameters when casting RHS of operator comparison. (Closed)

Created:
5 years, 3 months ago by pcc1
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use correct template parameters when casting RHS of operator comparison. Failing to use the correct Pred and Hash parameters results in an invalid cast for operators with custom Pred and Hash parameters, e.g. double. Cleanup for cfi_vptr=1; see https://www.chromium.org/developers/testing/control-flow-integrity BUG=chromium:457523 R=bmeurer@chromium.org LOG=N

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/operator.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
pcc1
5 years, 3 months ago (2015-09-01 03:59:59 UTC) #1
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-09-01 04:04:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309903005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309903005/1
5 years, 3 months ago (2015-09-01 04:16:24 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/9312)
5 years, 3 months ago (2015-09-01 04:17:11 UTC) #6
pcc1
5 years, 3 months ago (2015-09-01 05:28:41 UTC) #7
On 2015/09/01 04:17:11, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   v8_mac_rel on tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/9312)

Looks like this is redundant with https://codereview.chromium.org/1314473007;
closing.

Powered by Google App Engine
This is Rietveld 408576698