Introduce composed tree version of enclosingNodeOfType()

Introduce composed tree version of enclosingNodeOfType()

This patch introduces composed tree version of |enclosingNodeOfType()| as a
preparation of introducing composed tree version of |enclosingBlock()| for
templatizing |VisiblePosition| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=webkit_unit_tests --gtest_fitler=EditingUtilitiesTest.enclosingNodeOfType

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201201

[yosin_UTC9, 2015-08-26 04:32:30]

yosin@chromium.org changed reviewers:
+ hajimehoshi@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2015-08-26 04:32:31]

PTAL

[hajimehoshi, 2015-08-26 04:50:53]

lgtm

https://codereview.chromium.org/1309903003/diff/1/Source/core/editing/Editing...
File Source/core/editing/EditingUtilities.h (right):

https://codereview.chromium.org/1309903003/diff/1/Source/core/editing/Editing...
Source/core/editing/EditingUtilities.h:132: CORE_EXPORT bool isBlock(const
Node*);
Is this a global function? I guess the name isBlock is too general. How about
renaming in another CL?

[yosin_UTC9, 2015-08-26 04:53:13]

Thanks for reviewing!

https://codereview.chromium.org/1309903003/diff/1/Source/core/editing/Editing...
File Source/core/editing/EditingUtilities.h (right):

https://codereview.chromium.org/1309903003/diff/1/Source/core/editing/Editing...
Source/core/editing/EditingUtilities.h:132: CORE_EXPORT bool isBlock(const
Node*);
On 2015/08/26 04:50:53, hajimehoshi wrote:
> Is this a global function? I guess the name isBlock is too general. How about
> renaming in another CL?

Good catch. I'll rename it to another name, e.g. isBlockElement(Node*).
Still short?

[yosin_UTC9, 2015-08-26 04:53:17]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2015-08-26 04:53:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1309903003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1309903003/1

[hajimehoshi, 2015-08-26 04:55:28]

https://codereview.chromium.org/1309903003/diff/1/Source/core/editing/Editing...
File Source/core/editing/EditingUtilities.h (right):

https://codereview.chromium.org/1309903003/diff/1/Source/core/editing/Editing...
Source/core/editing/EditingUtilities.h:132: CORE_EXPORT bool isBlock(const
Node*);
On 2015/08/26 04:53:13, Yosi_UTC9 wrote:
> On 2015/08/26 04:50:53, hajimehoshi wrote:
> > Is this a global function? I guess the name isBlock is too general. How
about
> > renaming in another CL?
> 
> Good catch. I'll rename it to another name, e.g. isBlockElement(Node*).
> Still short?

isBlockElement would be much better (as long as an element named 'block' doesn't
exist).

[commit-bot: I haz the power, 2015-08-26 05:38:02]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201201

[yosin_UTC9, 2015-08-26 05:58:50]

On 2015/08/26 04:55:28, hajimehoshi wrote:
>
https://codereview.chromium.org/1309903003/diff/1/Source/core/editing/Editing...
> File Source/core/editing/EditingUtilities.h (right):
> 
>
https://codereview.chromium.org/1309903003/diff/1/Source/core/editing/Editing...
> Source/core/editing/EditingUtilities.h:132: CORE_EXPORT bool isBlock(const
> Node*);
> On 2015/08/26 04:53:13, Yosi_UTC9 wrote:
> > On 2015/08/26 04:50:53, hajimehoshi wrote:
> > > Is this a global function? I guess the name isBlock is too general. How
> about
> > > renaming in another CL?
> > 
> > Good catch. I'll rename it to another name, e.g. isBlockElement(Node*).
> > Still short?
> 
> isBlockElement would be much better (as long as an element named 'block'
doesn't
> exist).

As discussed with layout/css expert, it is better to call
isEnclosingBlock(Node*).
The definition of isBlock() isn't clear both layout and CSS points of views.