Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: Source/core/editing/EditingUtilities.h

Issue 1309903003: Introduce composed tree version of enclosingNodeOfType() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-26T13:10:19 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/editing/EditingUtilities.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/EditingUtilities.h
diff --git a/Source/core/editing/EditingUtilities.h b/Source/core/editing/EditingUtilities.h
index 0a396dfb4de92cbcd2db1430ccc0a5b5133b12ba..9a9866bef17a312042e8f86a72fc3ee1401bae94 100644
--- a/Source/core/editing/EditingUtilities.h
+++ b/Source/core/editing/EditingUtilities.h
@@ -78,7 +78,8 @@ Element* associatedElementOf(const Position&);
Node* enclosingEmptyListItem(const VisiblePosition&);
Element* enclosingAnchorElement(const Position&);
Element* enclosingElementWithTag(const Position&, const QualifiedName&);
-Node* enclosingNodeOfType(const Position&, bool (*nodeIsOfType)(const Node*), EditingBoundaryCrossingRule = CannotCrossEditingBoundary);
+CORE_EXPORT Node* enclosingNodeOfType(const Position&, bool (*nodeIsOfType)(const Node*), EditingBoundaryCrossingRule = CannotCrossEditingBoundary);
+CORE_EXPORT Node* enclosingNodeOfType(const PositionInComposedTree&, bool (*nodeIsOfType)(const Node*), EditingBoundaryCrossingRule = CannotCrossEditingBoundary);
HTMLSpanElement* tabSpanElement(const Node*);
Element* isLastPositionBeforeTable(const VisiblePosition&);
@@ -128,7 +129,7 @@ inline bool canHaveChildrenForEditing(const Node* node)
}
bool isAtomicNode(const Node*);
-bool isBlock(const Node*);
+CORE_EXPORT bool isBlock(const Node*);
hajimehoshi 2015/08/26 04:50:53 Is this a global function? I guess the name isBloc
yosin_UTC9 2015/08/26 04:53:13 Good catch. I'll rename it to another name, e.g. i
hajimehoshi 2015/08/26 04:55:28 isBlockElement would be much better (as long as an
bool isInline(const Node*);
bool isTabHTMLSpanElement(const Node*);
bool isTabHTMLSpanElementTextNode(const Node*);
« no previous file with comments | « no previous file | Source/core/editing/EditingUtilities.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698