Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 130983006: Revert of Replace RenderFullScreen with top layer (Closed)

Created:
6 years, 11 months ago by Alpha Left Google
Modified:
6 years, 11 months ago
CC:
blink-reviews, zoltan1, dsinclair, sof, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, blink-layers+watch_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears, bemjb+rendering_chromium.org, Inactive
Visibility:
Public.

Description

Revert of Replace RenderFullScreen with top layer Revert r165710 because of unit test failures. TBR=gavinp Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165801

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+425 lines, -293 lines) Patch
M LayoutTests/TestExpectations View 3 chunks +3 lines, -5 lines 0 comments Download
D LayoutTests/fast/dom/HTMLDialogElement/fullscreen-elements-do-not-affect-modality.html View 1 chunk +0 lines, -105 lines 0 comments Download
D LayoutTests/fast/dom/HTMLDialogElement/fullscreen-elements-do-not-affect-modality-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fullscreen/full-screen-is-in-top-layer.html View 1 chunk +0 lines, -40 lines 0 comments Download
A LayoutTests/fullscreen/full-screen-placeholder.html View 1 chunk +73 lines, -0 lines 0 comments Download
A + LayoutTests/fullscreen/full-screen-placeholder-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
D LayoutTests/fullscreen/full-screen-video-has-backdrop.html View 1 chunk +0 lines, -31 lines 0 comments Download
A + LayoutTests/platform/linux/fullscreen/parent-flow-inline-with-block-child-expected.png View Binary file 0 comments Download
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/fullscreen.css View 1 chunk +1 line, -22 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +3 lines, -9 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.h View 3 chunks +6 lines, -0 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.cpp View 10 chunks +50 lines, -14 lines 0 comments Download
M Source/core/dom/RenderTreeBuilder.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M Source/core/html/HTMLDialogElement.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLDialogElement.cpp View 4 chunks +0 lines, -10 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 3 chunks +1 line, -16 lines 0 comments Download
A + Source/core/rendering/RenderFullScreen.h View 2 chunks +23 lines, -19 lines 0 comments Download
A Source/core/rendering/RenderFullScreen.cpp View 1 chunk +189 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 2 chunks +12 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderVideo.h View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderVideo.cpp View 2 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Alpha Left Google
Committed patchset #1 manually as r165801 (presubmit successful).
6 years, 11 months ago (2014-01-25 00:27:22 UTC) #1
Alpha Left Google
6 years, 11 months ago (2014-01-25 00:27:37 UTC) #2
Message was sent while issue was closed. 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698