chrome/browser/android/banners/app_banner_manager_android.cc - Issue 1309803005: Allow direct and indirect navigation values to be varied via field trial.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 1309803005: Allow direct and indirect navigation values to be varied via field trial. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix broken test that trybots didn't catch Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java ('k') | chrome/browser/banners/app_banner_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/banners/app_banner_manager_android.cc

diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc

index 953c0e934e4eca9adaf4821cb644dc182130c3fd..443d9e1d3b0d3433cea812fe5cadfce0afd6ff22 100644

--- a/chrome/browser/android/banners/app_banner_manager_android.cc

+++ b/chrome/browser/android/banners/app_banner_manager_android.cc

@@ -181,12 +181,12 @@ void DisableSecureSchemeCheckForTesting(JNIEnv* env, jclass clazz) {

AppBannerManager::DisableSecureSchemeCheckForTesting();

}

-void ForceEngagementWeightsForTesting(JNIEnv* env,

- jclass clazz,

- jdouble direct_engagement,

- jdouble indirect_engagement) {

- AppBannerManager::ForceEngagementWeightsForTesting(direct_engagement,

- indirect_engagement);

+void SetEngagementWeights(JNIEnv* env,

+ jclass clazz,

+ jdouble direct_engagement,

+ jdouble indirect_engagement) {

+ AppBannerManager::SetEngagementWeights(direct_engagement,

+ indirect_engagement);

}

jboolean IsEnabled(JNIEnv* env, jclass clazz) {