chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java - Issue 1309803005: Allow direct and indirect navigation values to be varied via field trial.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

Issue 1309803005: Allow direct and indirect navigation values to be varied via field trial. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix broken test that trybots didn't catch Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java ('k') | chrome/browser/android/banners/app_banner_manager_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

index 1efe57337b4b34085ade534dd5634021d369d4cc..80cef4a5d1bba99c3f779c8a4cec1a2ee316fa56 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

@@ -56,7 +56,9 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {

private static final String NATIVE_APP_INSTALL_TEXT = "Install this";

- private static final String NATIVE_APP_REFERRER = "chrome_inline";

+ private static final String NATIVE_APP_REFERRER = "chrome_inline&playinline=chrome_inline";

+ private static final String NATIVE_APP_BLANK_REFERRER = "playinline=chrome_inline";

private static final String NATIVE_APP_URL_WITH_MANIFEST_URL =

TestHttpServerClient.getUrl("chrome/test/data/banners/play_app_url_test_page.html");

@@ -154,7 +156,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {

// Navigations in this test are all of type ui::PAGE_TRANSITION_LINK, i.e. indirect.

// Force indirect navigations to be worth the same as direct for testing.

- AppBannerManager.forceEngagementWeightsForTesting(1, 1);

+ AppBannerManager.setEngagementWeights(1, 1);

}

private boolean waitUntilNoInfoBarsExist() throws Exception {

@@ -259,7 +261,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {

@SmallTest

@Feature({"AppBanners"})

public void testFullNativeInstallPathwayFromId() throws Exception {

- runFullNativeInstallPathway(NATIVE_APP_URL, "");

+ runFullNativeInstallPathway(NATIVE_APP_URL, NATIVE_APP_BLANK_REFERRER);

}

@SmallTest