Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1309763002: Clean up ifdefs in SkGifCodec (Closed)

Created:
5 years, 4 months ago by msarett
Modified:
5 years, 3 months ago
Reviewers:
scroggo, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up ifdefs in SkGifCodec Since codec uses the same version of giflib everywhere, I believe these are unnecessary. BUG=skia: Committed: https://skia.googlesource.com/skia/+/b30e9d3960567571946ed89cbe7f5a2bd8255f85

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M src/codec/SkCodec_libgif.cpp View 6 chunks +0 lines, -23 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
msarett
https://codereview.chromium.org/1309763002/diff/1/src/codec/SkCodec_libgif.cpp File src/codec/SkCodec_libgif.cpp (right): https://codereview.chromium.org/1309763002/diff/1/src/codec/SkCodec_libgif.cpp#newcode70 src/codec/SkCodec_libgif.cpp:70: #if GIFLIB_MAJOR < 5 || (GIFLIB_MAJOR == 5 && ...
5 years, 4 months ago (2015-08-21 13:24:26 UTC) #2
djsollen
lgtm
5 years, 4 months ago (2015-08-21 13:51:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309763002/1
5 years, 4 months ago (2015-08-21 13:52:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b30e9d3960567571946ed89cbe7f5a2bd8255f85
5 years, 4 months ago (2015-08-21 13:58:46 UTC) #6
scroggo
5 years, 3 months ago (2015-08-26 16:52:49 UTC) #7
Message was sent while issue was closed.
FWIW, any time *we* build SkGifCodec, we'll use a particular version of giflib,
but in theory, some external project could build Skia using a different version
(or even just use the version installed on their local machine). I do not know
whether it makes sense to support that use case. (And the code is definitely
cleaner this way!)

Powered by Google App Engine
This is Rietveld 408576698