Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1309733002: [heap] Move StoreBufferRebuilder into the correct header. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-regexp-result-cache
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Move StoreBufferRebuilder into the correct header. R=mlippautz@chromium.org Committed: https://crrev.com/d6ef00b98f358d3a7de5fe851c1e965f485ee8c3 Cr-Commit-Position: refs/heads/master@{#30304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -69 lines) Patch
M src/heap/heap.h View 1 chunk +0 lines, -19 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M src/heap/store-buffer.h View 1 chunk +20 lines, -0 lines 0 comments Download
M src/heap/store-buffer.cc View 1 chunk +51 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-21 12:22:46 UTC) #1
Michael Lippautz
lgtm
5 years, 4 months ago (2015-08-21 12:31:09 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 4 months ago (2015-08-21 12:46:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309733002/1
5 years, 4 months ago (2015-08-21 12:59:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-21 13:00:53 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 13:01:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6ef00b98f358d3a7de5fe851c1e965f485ee8c3
Cr-Commit-Position: refs/heads/master@{#30304}

Powered by Google App Engine
This is Rietveld 408576698