Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1306053003: [heap] Move RegExpResultCache out of the heap. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Move RegExpResultCache out of the heap. R=yangguo@chromium.org,hpayer@chromium.org Committed: https://crrev.com/24ef80dc93deba21256e9c270683f47036c9b32d Cr-Commit-Position: refs/heads/master@{#30300}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -117 lines) Patch
M src/heap/heap.h View 1 chunk +0 lines, -24 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M src/regexp/jsregexp.h View 1 chunk +25 lines, -1 line 0 comments Download
M src/regexp/jsregexp.cc View 1 chunk +93 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1309733002 Patch 1

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-21 12:10:42 UTC) #2
Yang
On 2015/08/21 12:10:42, Michael Starzinger wrote: lgtm.
5 years, 4 months ago (2015-08-21 12:12:43 UTC) #3
Hannes Payer (out of office)
lgtm
5 years, 4 months ago (2015-08-21 12:16:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306053003/1
5 years, 4 months ago (2015-08-21 12:20:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-21 12:34:23 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 12:34:37 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/24ef80dc93deba21256e9c270683f47036c9b32d
Cr-Commit-Position: refs/heads/master@{#30300}

Powered by Google App Engine
This is Rietveld 408576698