Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1309563003: Add a dummy WebSourceBufferImpl::evictCodedFrames (Closed)

Created:
5 years, 4 months ago by servolk
Modified:
5 years, 4 months ago
Reviewers:
wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a dummy WebSourceBufferImpl::evictCodedFrames BUG=none Committed: https://crrev.com/49f79129a855b65f7ffc9a3204c31309a93247c2 Cr-Commit-Position: refs/heads/master@{#344678}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M media/blink/websourcebuffer_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/blink/websourcebuffer_impl.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
servolk
5 years, 4 months ago (2015-08-21 01:37:30 UTC) #2
wolenetz
lgtm % nit https://codereview.chromium.org/1309563003/diff/1/media/blink/websourcebuffer_impl.cc File media/blink/websourcebuffer_impl.cc (right): https://codereview.chromium.org/1309563003/diff/1/media/blink/websourcebuffer_impl.cc#newcode86 media/blink/websourcebuffer_impl.cc:86: // TODO(servolk): A dummy method to ...
5 years, 4 months ago (2015-08-21 01:41:11 UTC) #3
servolk
https://codereview.chromium.org/1309563003/diff/1/media/blink/websourcebuffer_impl.cc File media/blink/websourcebuffer_impl.cc (right): https://codereview.chromium.org/1309563003/diff/1/media/blink/websourcebuffer_impl.cc#newcode86 media/blink/websourcebuffer_impl.cc:86: // TODO(servolk): A dummy method to facilitate langing MSE ...
5 years, 4 months ago (2015-08-21 01:43:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309563003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309563003/20001
5 years, 4 months ago (2015-08-21 01:44:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-21 03:45:06 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 03:45:54 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/49f79129a855b65f7ffc9a3204c31309a93247c2
Cr-Commit-Position: refs/heads/master@{#344678}

Powered by Google App Engine
This is Rietveld 408576698