Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1391)

Issue 1309523008: Change IdleCallbackDeadline.timeRemaining to be a function instead of an attribute. (Closed)

Created:
5 years, 3 months ago by rmcilroy
Modified:
5 years, 3 months ago
Reviewers:
esprehn
CC:
aerotwist, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, igrigorik, rwlbuis, sof, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Change IdleCallbackDeadline.timeRemaining to be a function instead of an attribute. BUG=514651 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201637

Patch Set 1 #

Patch Set 2 : Add webexposed change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M LayoutTests/virtual/threaded/fast/idle-callback/basic.html View 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/virtual/threaded/fast/idle-callback/timeout.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/IdleCallbackDeadline.idl View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (9 generated)
rmcilroy
Elliott, as discussed. Please take a look, thanks. igrigorik/aerotwist, FYI.
5 years, 3 months ago (2015-09-01 16:23:34 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309523008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309523008/1
5 years, 3 months ago (2015-09-01 16:24:04 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/101585)
5 years, 3 months ago (2015-09-01 17:27:37 UTC) #6
esprehn
lgtm
5 years, 3 months ago (2015-09-01 21:40:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309523008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309523008/20001
5 years, 3 months ago (2015-09-02 09:23:35 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/107076)
5 years, 3 months ago (2015-09-02 10:18:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309523008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309523008/40001
5 years, 3 months ago (2015-09-02 11:08:42 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 12:21:49 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201637

Powered by Google App Engine
This is Rietveld 408576698