LayoutTests/virtual/threaded/fast/idle-callback/timeout.html - Issue 1309523008: Change IdleCallbackDeadline.timeRemaining to be a function instead of an attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/virtual/threaded/fast/idle-callback/timeout.html

Issue 1309523008: Change IdleCallbackDeadline.timeRemaining to be a function instead of an attribute. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add webexposed change Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/virtual/threaded/fast/idle-callback/basic.html ('k') | LayoutTests/webexposed/global-interface-listing-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/virtual/threaded/fast/idle-callback/timeout.html

diff --git a/LayoutTests/virtual/threaded/fast/idle-callback/timeout.html b/LayoutTests/virtual/threaded/fast/idle-callback/timeout.html

index cbf0a2d38550b89c2af58563c1e68a14958a6a14..7a2e62d3dda52444537649c20bc0b9ef57ca5822 100644

--- a/LayoutTests/virtual/threaded/fast/idle-callback/timeout.html

+++ b/LayoutTests/virtual/threaded/fast/idle-callback/timeout.html

@@ -44,7 +44,7 @@ async_test(function() {

var idle_callback = this.step_func(function(deadline) {

var time_delta = performance.now() - idle_callback_scheduled;

assert_true(time_delta >= timeout, "Should only have been run after timeout");

- assert_true(deadline.timeRemaining == 0, "IdleDeadline.timeRemaining MUST be equal to zero if requestIdleCallback was scheduled due to a timeout");

+ assert_true(deadline.timeRemaining() == 0, "IdleDeadline.timeRemaining MUST be equal to zero if requestIdleCallback was scheduled due to a timeout");

assert_true(deadline.didTimeout, "IdleDeadline.didTimeout MUST be true if requestIdleCallback was scheduled due to a timeout");

assert_true(busy_raf_loop_iterations_remaining > 0, "Busy rAF loop should still be going");

this.done();