Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1309403002: Show closed/open shadow root in inspector (Closed)

Created:
5 years, 4 months ago by kochi
Modified:
5 years, 4 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Show closed/open shadow root in inspector Author shadow roots used to show in inspector as "#shadow-root", but with this CL it will be shown as "#shadow-root (open)" or "#shadow-root (closed)" respectively. BUG=516969 TEST=pass all layout tests Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201184

Patch Set 1 #

Patch Set 2 : expect to pass layout tests #

Patch Set 3 : add minimal case for closed shadow root #

Patch Set 4 : update test expectation for breadcrumb #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -31 lines) Patch
M LayoutTests/inspector/elements/edit/edit-dom-actions-shadow-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/elements/shadow/breadcrumb-shadow-roots.html View 1 2 4 chunks +16 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/shadow/breadcrumb-shadow-roots-expected.txt View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/shadow/create-shadow-root-expected.txt View 1 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/shadow/elements-panel-shadow-selection-on-refresh.html View 1 2 5 chunks +24 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/shadow/elements-panel-shadow-selection-on-refresh-expected.txt View 1 2 2 chunks +9 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/shadow/shadow-host-display-modes-expected.txt View 1 8 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/inspector/elements/shadow/shadow-root-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/shadow/update-shadowdom-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/elements/ElementsTreeElement.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sdk/DOMModel.js View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
kochi
Hi Dmitry, Could you review this, or assign to someone appropriate? Thanks,
5 years, 4 months ago (2015-08-25 06:40:06 UTC) #2
pfeldman
lgtm
5 years, 4 months ago (2015-08-25 20:36:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309403002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309403002/60001
5 years, 4 months ago (2015-08-26 01:11:34 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-26 02:34:28 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201184

Powered by Google App Engine
This is Rietveld 408576698