Source/devtools/front_end/sdk/DOMModel.js - Issue 1309403002: Show closed/open shadow root in inspector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/sdk/DOMModel.js

Issue 1309403002: Show closed/open shadow root in inspector (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: update test expectation for breadcrumb Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/sdk/DOMModel.js

diff --git a/Source/devtools/front_end/sdk/DOMModel.js b/Source/devtools/front_end/sdk/DOMModel.js

index 645e32f0bf227bcdf2eaa95ed490234378fe346d..aec85a2d3bb4339c0397570197acb0f23340e69b 100644

--- a/Source/devtools/front_end/sdk/DOMModel.js

+++ b/Source/devtools/front_end/sdk/DOMModel.js

@@ -136,7 +136,8 @@ WebInspector.DOMNode.PseudoElementNames = {

WebInspector.DOMNode.ShadowRootTypes = {

UserAgent: "user-agent",

- Author: "author"

+ Open: "open",

+ Closed: "closed"

}

WebInspector.DOMNode.prototype = {

@@ -345,7 +346,7 @@ WebInspector.DOMNode.prototype = {

{

var shadowRootType = this.shadowRootType();

if (shadowRootType)

- return "#shadow-root" + (shadowRootType === WebInspector.DOMNode.ShadowRootTypes.UserAgent ? " (user-agent)" : "");

+ return "#shadow-root (" + shadowRootType + ")";

return this.isXMLNode() ? this.nodeName() : this.nodeName().toLowerCase();