Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3487)

Unified Diff: chrome/browser/sync/glue/synced_tab_delegate_unittest.cc

Issue 1309323004: Create a NavigationEntry for the initial blank page. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix GetEntryCount, more tests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/synced_tab_delegate_unittest.cc
diff --git a/chrome/browser/sync/glue/synced_tab_delegate_unittest.cc b/chrome/browser/sync/glue/synced_tab_delegate_unittest.cc
index ee848ee05b10d005148b2251109986628aae722a..f6b06230210846e3ca7d9107dd116a662afe72f0 100644
--- a/chrome/browser/sync/glue/synced_tab_delegate_unittest.cc
+++ b/chrome/browser/sync/glue/synced_tab_delegate_unittest.cc
@@ -44,6 +44,11 @@ class FakeSyncedTabDelegate : public SyncedTabDelegate {
bool IsBeingDestroyed() const override { return false; }
Profile* profile() const override { return NULL; }
std::string GetExtensionAppId() const override { return ""; }
+ bool IsInitialBlankNavigation() const override {
+ // This differs from NavigationControllerImpl, which has an initial blank
+ // NavigationEntry.
+ return GetEntryCount() == 0;
+ }
int GetCurrentEntryIndex() const override { return current_index_; }
int GetEntryCount() const override { return indexed_entries_.size(); }
int GetPendingEntryIndex() const override { return pending_index_; }

Powered by Google App Engine
This is Rietveld 408576698