Add /Zc:sizedDealloc- to work around VS 2015 bug

Add /Zc:sizedDealloc- to work around VS 2015 bug

VS 2015's support for VC++ 14 sized deallocs causes __global_delete
to be exported from many object files, causing obscure and hard to
track linker errors.

The best workaround, as suggested here:

https://connect.microsoft.com/VisualStudio/feedback/details/1379741/-global-delete-function-is-inconsistently-generated

Is to use /Zc:sizedDealloc- to disable the new C++14 feature support
that is triggering this behavior change.

R=scottmg@chromium.org
BUG=526851
Committed: https://crrev.com/690f7eab5ea2a2a7abb33100a37e5526947b1f22
Cr-Commit-Position: refs/heads/master@{#346671}

[brucedawson, 2015-08-31 23:24:31]

Scott, this fixes the current VS 2015 debug build problem.
Can you take a look?

I can't test the gn fix because I can't get VS 2015 project
files generated. It appears that if I set visual_studio_version
then I have to set visual_studio_path and wdk_path and I'm
not sure what wdk_path is supposed to be set to, and whether
VS 2015 is even supported by gn. Setting my gn args to this was
not sufficient:

visual_studio_version = 2015
visual_studio_path = "c:\Program Files (x86)\Microsoft Visual Studio 14.0"

See the linked bug for the gory details.

[scottmg, 2015-08-31 23:31:58]

lgtm, I don't think anyone has tried to get GN vs2015 working yet (other than
you now, I guess :).

https://codereview.chromium.org/1309263004/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1309263004/diff/20001/build/common.gypi#newco...
build/common.gypi:3338: # Work around crbug.com/526851, bug in VS 2015 RTM
compiler
nit; '.' at end of comment.

[scottmg, 2015-08-31 23:33:00]

(Nice hunting, btw!)

[brucedawson, 2015-08-31 23:37:12]

Periods added to both comments. Committing now.

https://codereview.chromium.org/1309263004/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1309263004/diff/20001/build/common.gypi#newco...
build/common.gypi:3338: # Work around crbug.com/526851, bug in VS 2015 RTM
compiler
On 2015/08/31 23:31:58, scottmg wrote:
> nit; '.' at end of comment.

Done.

[brucedawson, 2015-08-31 23:37:24]

The CQ bit was checked by brucedawson@chromium.org

[brucedawson, 2015-08-31 23:37:24]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1309263004/#ps40001
(title: "Add periods to comments.")

[commit-bot: I haz the power, 2015-08-31 23:38:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1309263004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1309263004/40001

[commit-bot: I haz the power, 2015-08-31 23:43:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-31 23:43:19]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[scottmg, 2015-08-31 23:45:02]

On 2015/08/31 23:43:19, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
>   ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
>   ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

I was wondering if that would work... Darn.

[brucedawson, 2015-09-01 05:14:23]

That's what I get for skipping the "git cl try" step.

It passes now. PTAL?

[scottmg, 2015-09-01 16:07:54]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2015-09-01 16:07:55]

lgtm

[commit-bot: I haz the power, 2015-09-01 16:08:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1309263004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1309263004/80001

[commit-bot: I haz the power, 2015-09-01 16:45:50]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-01 16:47:24]

Patchset 5 (id:??) landed as
https://crrev.com/690f7eab5ea2a2a7abb33100a37e5526947b1f22
Cr-Commit-Position: refs/heads/master@{#346671}