Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Side by Side Diff: build/common.gypi

Issue 1309263004: Add /Zc:sizedDealloc- to work around VS 2015 bug (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding gn support. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3313 matching lines...) Expand 10 before | Expand all | Expand 10 after
3324 'Profile': 'false', 3324 'Profile': 'false',
3325 'AdditionalOptions': [ 3325 'AdditionalOptions': [
3326 # Tell VS 2015+ to create a PDB that references debug 3326 # Tell VS 2015+ to create a PDB that references debug
3327 # information in .obj and .lib files instead of copying 3327 # information in .obj and .lib files instead of copying
3328 # it all. 3328 # it all.
3329 '/DEBUG:FASTLINK', 3329 '/DEBUG:FASTLINK',
3330 ], 3330 ],
3331 }, 3331 },
3332 }, 3332 },
3333 }], 3333 }],
3334 ['MSVS_VERSION == "2015"', {
3335 'msvs_settings': {
3336 'VCCLCompilerTool': {
3337 'AdditionalOptions': [
3338 # Work around crbug.com/526851, bug in VS 2015 RTM compiler
scottmg 2015/08/31 23:31:58 nit; '.' at end of comment.
brucedawson 2015/08/31 23:37:12 Done.
3339 '/Zc:sizedDealloc-',
3340 ],
3341 },
3342 },
3343 }],
3334 ], 3344 ],
3335 }, 3345 },
3336 'x86_Base': { 3346 'x86_Base': {
3337 'abstract': 1, 3347 'abstract': 1,
3338 'msvs_settings': { 3348 'msvs_settings': {
3339 'VCLinkerTool': { 3349 'VCLinkerTool': {
3340 'MinimumRequiredVersion': '5.01', # XP. 3350 'MinimumRequiredVersion': '5.01', # XP.
3341 'TargetMachine': '1', 3351 'TargetMachine': '1',
3342 }, 3352 },
3343 'VCLibrarianTool': { 3353 'VCLibrarianTool': {
(...skipping 2969 matching lines...) Expand 10 before | Expand all | Expand 10 after
6313 # settings in target dicts. SYMROOT is a special case, because many other 6323 # settings in target dicts. SYMROOT is a special case, because many other
6314 # Xcode variables depend on it, including variables such as 6324 # Xcode variables depend on it, including variables such as
6315 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6325 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6316 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6326 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6317 # files to appear (when present) in the UI as actual files and not red 6327 # files to appear (when present) in the UI as actual files and not red
6318 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6328 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6319 # and therefore SYMROOT, needs to be set at the project level. 6329 # and therefore SYMROOT, needs to be set at the project level.
6320 'SYMROOT': '<(DEPTH)/xcodebuild', 6330 'SYMROOT': '<(DEPTH)/xcodebuild',
6321 }, 6331 },
6322 } 6332 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698