Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1309163003: Add a separate scope for switch (Closed)

Created:
5 years, 4 months ago by Dan Ehrenberg
Modified:
5 years, 4 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a separate scope for switch The ES2015 specification for switch statements 13.12.11 specifies that they get their own lexical scope. This patch introduces such a scope through a complex desugaring in terms of blocks, done so that Crankshaft does not have to be updated to support multiple constructs providing scopes. Recommitting this patch after a bug fix in Crankshaft to allow a desugaring with certain elements missing a source location: https://codereview.chromium.org/1313443002 BUG=v8:4377 LOG=Y R=adamk Committed: https://crrev.com/45e2628df7bc4151a893f38794014082e0b269d5 Cr-Commit-Position: refs/heads/master@{#30340}

Patch Set 1 #

Patch Set 2 : Avoid arrow function in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -15 lines) Patch
M src/ast-value-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/parser.cc View 1 chunk +54 lines, -13 lines 0 comments Download
M src/scopes.h View 1 chunk +4 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-4377.js View 1 1 chunk +45 lines, -0 lines 0 comments Download
M test/mjsunit/switch.js View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Dan Ehrenberg
5 years, 4 months ago (2015-08-24 18:11:34 UTC) #1
adamk
lgtm
5 years, 4 months ago (2015-08-24 18:13:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309163003/1
5 years, 4 months ago (2015-08-24 18:17:24 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/8995)
5 years, 4 months ago (2015-08-24 18:27:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309163003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309163003/20001
5 years, 4 months ago (2015-08-24 18:31:38 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-24 18:57:13 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 18:57:31 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/45e2628df7bc4151a893f38794014082e0b269d5
Cr-Commit-Position: refs/heads/master@{#30340}

Powered by Google App Engine
This is Rietveld 408576698