Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1313443002: Translate AST to Hydrogen missing position (Closed)

Created:
5 years, 4 months ago by Dan Ehrenberg
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Translate AST to Hydrogen missing position This patch translates RelocInfo::kNoPosition to SourcePosition::Unknown() in constructing the Hydrogen graph from the parser's output. The translation is done to increase the flexibility of the parser to desugar more things that don't have natural locations. R=bmeurer@chromium.org BUG=v8:4377 LOG=N Committed: https://crrev.com/032a35ffb6d625c9a0639c3afd54181938ac49a3 Cr-Commit-Position: refs/heads/master@{#30337}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/hydrogen.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Dan Ehrenberg
5 years, 4 months ago (2015-08-22 02:01:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313443002/1
5 years, 4 months ago (2015-08-22 02:01:59 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-22 02:26:10 UTC) #5
Benedikt Meurer
lgtm
5 years, 4 months ago (2015-08-22 06:59:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313443002/1
5 years, 4 months ago (2015-08-24 16:56:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-24 17:18:45 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 17:19:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/032a35ffb6d625c9a0639c3afd54181938ac49a3
Cr-Commit-Position: refs/heads/master@{#30337}

Powered by Google App Engine
This is Rietveld 408576698