Move painting code out of LayoutSVGResourceClipper

Move painting code out of LayoutSVGResourceClipper

LayoutSVGResourceClipper::tryPathOnlyClipping contains the code to
emit the path - if one is successfully built. For the sake of layering,
push this out into the caller (SVGClipPainter) instead.

Also replace uses of clipperResource().isEmpty() with hasClipper(),
rename objectBoundingBox referenceBox (to better match the Masking spec
terminology) and rename the tryPathOnlyClipping to asPath.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201254

[fs, 2015-08-26 18:22:31]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, pdr@chromium.org

[fs, 2015-08-26 18:22:32]

Apparently some part of the trybot infrastructure is unhappy, but don't see how
this should've changed any behavior.

https://codereview.chromium.org/1308983007/diff/1/Source/core/layout/svg/Layo...
File Source/core/layout/svg/LayoutSVGResourceClipper.h (right):

https://codereview.chromium.org/1308983007/diff/1/Source/core/layout/svg/Layo...
Source/core/layout/svg/LayoutSVGResourceClipper.h:49: bool asPath(const
AffineTransform&, const FloatRect& referenceBox, Path&);
Bikeshed fodder. Felt a name-change was in order with the (slight) change in
semantics, but not wedded to this particular name, so other suggestions welcome.

[f(malita), 2015-08-26 18:38:01]

lgtm

https://codereview.chromium.org/1308983007/diff/1/Source/core/layout/svg/Layo...
File Source/core/layout/svg/LayoutSVGResourceClipper.h (right):

https://codereview.chromium.org/1308983007/diff/1/Source/core/layout/svg/Layo...
Source/core/layout/svg/LayoutSVGResourceClipper.h:49: bool asPath(const
AffineTransform&, const FloatRect& referenceBox, Path&);
On 2015/08/26 18:22:32, fs wrote:
> Bikeshed fodder. Felt a name-change was in order with the (slight) change in
> semantics, but not wedded to this particular name, so other suggestions
welcome.

asPath sounds great to me.

[pdr., 2015-08-26 20:43:06]

LGTM 2

[pdr., 2015-08-26 20:43:15]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2015-08-26 20:44:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308983007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308983007/1

[commit-bot: I haz the power, 2015-08-26 22:16:22]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201254