Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1308863004: [interpreter] Allow verification and trace-turbo for bytecode handlers. (Closed)

Created:
5 years, 4 months ago by rmcilroy
Modified:
5 years, 4 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@ignition-visualize
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Allow verification and trace-turbo for bytecode handlers. BUG=v8:4280 LOG=N Committed: https://crrev.com/8e0aaffdcb17573db45c3bac8c93f56d4e96028b Cr-Commit-Position: refs/heads/master@{#30354}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -4 lines) Patch
M src/compiler/interpreter-assembler.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/compiler/pipeline.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
rmcilroy
This is the follow-on from https://codereview.chromium.org/1297203002/. PTAL, thanks.
5 years, 4 months ago (2015-08-21 18:08:47 UTC) #4
rmcilroy
Ping?
5 years, 4 months ago (2015-08-25 11:38:00 UTC) #5
titzer
Looks much better with the GetDebugName() changes. lgtm
5 years, 4 months ago (2015-08-25 11:46:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308863004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308863004/40001
5 years, 4 months ago (2015-08-25 12:33:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 4 months ago (2015-08-25 12:56:55 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 12:57:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e0aaffdcb17573db45c3bac8c93f56d4e96028b
Cr-Commit-Position: refs/heads/master@{#30354}

Powered by Google App Engine
This is Rietveld 408576698