extensions/common/extension_api.h - Issue 1308823002: Move Singleton and related structs to namespace base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/extension_api.h

Issue 1308823002: Move Singleton and related structs to namespace base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix more errors Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/trace_event/trace_log.cc ('K') | « extensions/browser/warning_service_factory.cc ('k') | extensions/shell/browser/api/vpn_provider/vpn_service_factory.cc » ('j') | ios/chrome/browser/favicon/favicon_service_factory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/extension_api.h

diff --git a/extensions/common/extension_api.h b/extensions/common/extension_api.h

index 8c7a689d1e11a3369d554519813574929a118ec8..715d8202fbe36bab2eb0fc8a21ada468d8a9440a 100644

--- a/extensions/common/extension_api.h

+++ b/extensions/common/extension_api.h

@@ -130,7 +130,7 @@ class ExtensionAPI {

private:

FRIEND_TEST_ALL_PREFIXES(ExtensionAPITest, DefaultConfigurationFeatures);

FRIEND_TEST_ALL_PREFIXES(ExtensionAPITest, TypesHaveNamespace);

- friend struct DefaultSingletonTraits<ExtensionAPI>;

+ friend struct base::DefaultSingletonTraits<ExtensionAPI>;

void InitDefaultConfiguration();