ios/chrome/browser/favicon/favicon_service_factory.h - Issue 1308823002: Move Singleton and related structs to namespace base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/favicon/favicon_service_factory.h

Issue 1308823002: Move Singleton and related structs to namespace base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix more errors Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/trace_event/trace_log.cc ('K') | « ios/chrome/browser/enhanced_bookmarks/enhanced_bookmark_model_factory.cc ('k') | ios/chrome/browser/favicon/favicon_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/favicon/favicon_service_factory.h

diff --git a/ios/chrome/browser/favicon/favicon_service_factory.h b/ios/chrome/browser/favicon/favicon_service_factory.h

index ebf31d2e9275210b255272a8e440692e8e272786..122cb5e8716ed2b62066abcdafb66154cb875123 100644

--- a/ios/chrome/browser/favicon/favicon_service_factory.h

+++ b/ios/chrome/browser/favicon/favicon_service_factory.h

@@ -10,7 +10,7 @@

#include "components/keyed_service/ios/browser_state_keyed_service_factory.h"

template <typename T>

-struct DefaultSingletonTraits;

+struct base::DefaultSingletonTraits;

sdefresne 2015/08/24 10:03:33 Are you sure this work? Shouldn't this instead be

enum class ServiceAccessType;

namespace favicon {

@@ -31,7 +31,7 @@ class FaviconServiceFactory : public BrowserStateKeyedServiceFactory {

static FaviconServiceFactory* GetInstance();

private:

- friend struct DefaultSingletonTraits<FaviconServiceFactory>;

+ friend struct base::DefaultSingletonTraits<FaviconServiceFactory>;

FaviconServiceFactory();

~FaviconServiceFactory() override;