chrome/chrome_browser_ui.gypi - Issue 1308713002: [Mac] Enable MacViews bookmark bubble behind --enable-mac-views-dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 1308713002: [Mac] Enable MacViews bookmark bubble behind --enable-mac-views-dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pulse

Patch Set: Address comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_browser_ui.gypi

diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi

index ebccfff39794c3d802e68efd3960f2971df7b0d4..0b441ff01ee532b231617051e1470fb214a7dbee 100644

--- a/chrome/chrome_browser_ui.gypi

+++ b/chrome/chrome_browser_ui.gypi

@@ -1974,8 +1974,12 @@

'browser/ui/views/apps/keyboard_hook_handler.h',

'browser/ui/views/apps/native_app_window_frame_view_mac.h',

'browser/ui/views/apps/native_app_window_frame_view_mac.mm',

+ 'browser/ui/views/bookmarks/bookmark_bubble_view.cc',

+ 'browser/ui/views/bookmarks/bookmark_bubble_view.h',

'browser/ui/views/bookmarks/bookmark_editor_view.cc',

'browser/ui/views/bookmarks/bookmark_editor_view.h',

+ 'browser/ui/views/bookmarks/bookmark_sync_promo_view.cc',

msw 2015/08/26 00:00:47 Did you actually test this with the sync promo?

jackhou1 2015/08/26 00:44:40 Yup, clicking on the "Sign in" link in a Views boo

+ 'browser/ui/views/bookmarks/bookmark_sync_promo_view.h',

'browser/ui/views/browser_dialogs_views_mac.cc',

'browser/ui/views/chrome_browser_main_extra_parts_views.cc',

'browser/ui/views/chrome_browser_main_extra_parts_views.h',

@@ -2069,8 +2073,6 @@

'browser/ui/views/bookmarks/bookmark_bar_view.cc',

'browser/ui/views/bookmarks/bookmark_bar_view.h',

'browser/ui/views/bookmarks/bookmark_bar_view_observer.h',

- 'browser/ui/views/bookmarks/bookmark_bubble_view.cc',

- 'browser/ui/views/bookmarks/bookmark_bubble_view.h',

'browser/ui/views/bookmarks/bookmark_context_menu.cc',

'browser/ui/views/bookmarks/bookmark_context_menu.h',

'browser/ui/views/bookmarks/bookmark_drag_drop_views.cc',

@@ -2079,8 +2081,6 @@

'browser/ui/views/bookmarks/bookmark_menu_controller_views.h',

'browser/ui/views/bookmarks/bookmark_menu_delegate.cc',

'browser/ui/views/bookmarks/bookmark_menu_delegate.h',

- 'browser/ui/views/bookmarks/bookmark_sync_promo_view.cc',

- 'browser/ui/views/bookmarks/bookmark_sync_promo_view.h',

'browser/ui/views/browser_dialogs_views.cc',

'browser/ui/views/certificate_selector.cc',

'browser/ui/views/certificate_selector.h',

« chrome/browser/ui/views/browser_dialogs_views_mac.cc ('K') | « chrome/browser/ui/views/frame/browser_view.cc ('k') | no next file » | no next file with comments »