chrome/browser/ui/views/frame/browser_view.cc - Issue 1308713002: [Mac] Enable MacViews bookmark bubble behind --enable-mac-views-dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1308713002: [Mac] Enable MacViews bookmark bubble behind --enable-mac-views-dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pulse

Patch Set: Address comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/browser_dialogs_views_mac.cc ('K') | « chrome/browser/ui/views/browser_dialogs_views_mac.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | chrome/chrome_browser_ui.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index a5dd7d2d067c2958daa30a1ba6df270cdbdaedda..e0643e2b28f57ed750254f3d465c5a3e8fb5992f 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -1238,10 +1238,8 @@ void BrowserView::ShowBookmarkBubble(const GURL& url, bool already_bookmarked) {

delegate.reset(new BookmarkBubbleSignInDelegate(browser_.get()));

BookmarkBubbleView::ShowBubble(GetToolbarView()->GetBookmarkBubbleAnchor(),

- bookmark_bar_view_.get(),

- delegate.Pass(),

- browser_->profile(),

- url,

+ gfx::Rect(), nullptr, bookmark_bar_view_.get(),

+ delegate.Pass(), browser_->profile(), url,

!already_bookmarked);

}