include/effects/SkMatrixConvolutionImageFilter.h - Issue 1308703007: Fix filter primitive bounds computations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/effects/SkMatrixConvolutionImageFilter.h

Issue 1308703007: Fix filter primitive bounds computations. (Closed) Base URL: https://skia.googlesource.com/skia.git@saveLayer-bounds-not-transformed

Patch Set: Fix comment style; remove useless param names Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/effects/SkMatrixConvolutionImageFilter.h

diff --git a/include/effects/SkMatrixConvolutionImageFilter.h b/include/effects/SkMatrixConvolutionImageFilter.h

index ef5ff72494be842773b129aedeeccd85441f6d59..09a3acf31a8579797dc3a951deab841d9f33af1f 100644

--- a/include/effects/SkMatrixConvolutionImageFilter.h

+++ b/include/effects/SkMatrixConvolutionImageFilter.h

@@ -79,7 +79,7 @@ protected:

bool onFilterImage(Proxy*, const SkBitmap& src, const Context&,

SkBitmap* result, SkIPoint* loc) const override;

- bool onFilterBounds(const SkIRect&, const SkMatrix&, SkIRect*) const override;

+ void onFilterNodeBounds(const SkIRect&, const SkMatrix&, SkIRect*, MapDirection) const override;

bool canComputeFastBounds() const override;

#if SK_SUPPORT_GPU

« no previous file with comments | « include/effects/SkDropShadowImageFilter.h ('k') | include/effects/SkMorphologyImageFilter.h » ('j') | src/core/SkRecordDraw.cpp » ('J')