include/effects/SkDropShadowImageFilter.h - Issue 1308703007: Fix filter primitive bounds computations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/effects/SkDropShadowImageFilter.h

Issue 1308703007: Fix filter primitive bounds computations. (Closed) Base URL: https://skia.googlesource.com/skia.git@saveLayer-bounds-not-transformed

Patch Set: Fix comment style; remove useless param names Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/effects/SkDropShadowImageFilter.h

diff --git a/include/effects/SkDropShadowImageFilter.h b/include/effects/SkDropShadowImageFilter.h

index bf4425e925f30f2784798cc38454d5740d731b06..bff1a42013774ea3784b189fe1447341e156bb51 100644

--- a/include/effects/SkDropShadowImageFilter.h

+++ b/include/effects/SkDropShadowImageFilter.h

@@ -35,7 +35,8 @@ protected:

void flatten(SkWriteBuffer&) const override;

bool onFilterImage(Proxy*, const SkBitmap& source, const Context&, SkBitmap* result,

SkIPoint* loc) const override;

- bool onFilterBounds(const SkIRect& src, const SkMatrix&, SkIRect* dst) const override;

+ void onFilterNodeBounds(const SkIRect& src, const SkMatrix&,

+ SkIRect* dst, MapDirection) const override;

private:

SkDropShadowImageFilter(SkScalar dx, SkScalar dy, SkScalar sigmaX, SkScalar sigmaY, SkColor,

« no previous file with comments | « include/effects/SkDisplacementMapEffect.h ('k') | include/effects/SkMatrixConvolutionImageFilter.h » ('j') | src/core/SkRecordDraw.cpp » ('J')