Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 1308663007: Deflake CustomLauncherPageBrowserTest.EventsActivateSwitchToCustomPage on ChromeOS Buildspec Tests (Closed)

Created:
5 years, 3 months ago by tapted
Modified:
5 years, 3 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deflake CustomLauncherPageBrowserTest.EventsActivateSwitchToCustomPage on ChromeOS Buildspec Tests The failure doesn't reproduce with --enable-pixel-output-in-tests, so I don't really know what's going on. But I suspect that since ChromeOS only checks the *target* visibility, it's possible for the app list to not be fully shown. One case this could happen is on official/buildspec builders which have more icons to load, and so the delayed-icon-load steps used for ChromeOS via AppListMainView::ShowAppListWhenReady() end up taking longer. Explicitly showing the app list ensures the app list is visible before the event generator tries to use it to generate mouse coordinates. BUG=525128 Committed: https://crrev.com/2e95c57b25f079105d3b822f3bc1de226bc3bbaa Cr-Commit-Position: refs/heads/master@{#347886}

Patch Set 1 #

Patch Set 2 : Better comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/apps/custom_launcher_page_browsertest_views.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
Hi Chris - please take a look
5 years, 3 months ago (2015-09-09 05:32:36 UTC) #2
calamity
lgtm
5 years, 3 months ago (2015-09-09 07:09:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308663007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308663007/20001
5 years, 3 months ago (2015-09-09 07:11:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-09 09:17:05 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 09:18:12 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2e95c57b25f079105d3b822f3bc1de226bc3bbaa
Cr-Commit-Position: refs/heads/master@{#347886}

Powered by Google App Engine
This is Rietveld 408576698