Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: chrome/browser/apps/custom_launcher_page_browsertest_views.cc

Issue 1308663007: Deflake CustomLauncherPageBrowserTest.EventsActivateSwitchToCustomPage on ChromeOS Buildspec Tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Better comment Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/custom_launcher_page_browsertest_views.cc
diff --git a/chrome/browser/apps/custom_launcher_page_browsertest_views.cc b/chrome/browser/apps/custom_launcher_page_browsertest_views.cc
index eb8aea103b038419bd586748c047d9248ab5cd47..78bd9d76e1bdc9c9226d5808bdb6c72f5ed16781 100644
--- a/chrome/browser/apps/custom_launcher_page_browsertest_views.cc
+++ b/chrome/browser/apps/custom_launcher_page_browsertest_views.cc
@@ -154,6 +154,12 @@ IN_PROC_BROWSER_TEST_F(CustomLauncherPageBrowserTest,
LoadAndLaunchPlatformApp(kCustomLauncherPagePath, "Launched");
// Use an event generator to ensure targeting is correct.
app_list::AppListView* app_list_view = GetAppListView();
+
+ // On ChromeOS, displaying the app list can be delayed while icons finish
+ // loading. Explicitly show it to ensure the event generator gets meaningful
+ // coordinates. See http://crbug.com/525128.
+ app_list_view->GetWidget()->Show();
+
app_list::ContentsView* contents_view =
app_list_view->app_list_main_view()->contents_view();
gfx::NativeWindow window = app_list_view->GetWidget()->GetNativeWindow();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698