Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1308663004: Don't leak TestPluginWebFrameClient in WebPluginContainerTests. (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
Reviewers:
chrishtr, Charlie Reis, pdr.
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Don't leak TestPluginWebFrameClient in WebPluginContainerTests. WebViewHelper::initializeAndLoad() doesn't take ownership of the optional frame client parameter. All other subclasses of TestWebFrameClient are constructed on the stack too. Fixes leaks like Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0x5b2ea0 in operator new(unsigned long) /b/build/slave/ClangToTLinuxASan/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:62 # #1 0x1799216 in blink::WebPluginContainerTest_Copy_Test::TestBody() third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp:242:99 # BUG=523910, 245126, 494827 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201487

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M Source/web/tests/WebPluginContainerTest.cpp View 1 2 7 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
(I'd send this to nasko@ but he's OoO for a few more days.)
5 years, 3 months ago (2015-08-29 21:28:28 UTC) #2
Nico
+chrishtr, pdr who recently-ish added two such leaks in https://codereview.chromium.org/1164683007 First to stamp wins!
5 years, 3 months ago (2015-08-29 21:38:36 UTC) #4
chrishtr
lgtm
5 years, 3 months ago (2015-08-31 15:51:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308663004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308663004/40001
5 years, 3 months ago (2015-08-31 15:51:31 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 17:59:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201487

Powered by Google App Engine
This is Rietveld 408576698