Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1164683007: Copy SkMetaData before painting printed plugin contents. (Closed)

Created:
5 years, 6 months ago by chrishtr
Modified:
5 years, 6 months ago
Reviewers:
pdr.
CC:
blink-reviews, Rik, danakj, dshwang, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Copy SkMetaData before painting printed plugin contents. The SkMetaData is necessary for the printing code to determine what PDF is being printed. See: https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/pepper/pepper_plugin_instance_impl.cc&sq=package:chromium&type=cs&l=1980&rcl=1433159508 BUG=494827 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196606

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -20 lines) Patch
M Source/platform/graphics/GraphicsContext.h View 1 2 3 4 5 6 6 chunks +9 lines, -3 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 1 2 3 4 5 6 4 chunks +15 lines, -5 lines 0 comments Download
M Source/platform/graphics/paint/SkPictureBuilder.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 2 3 4 5 6 7 8 5 chunks +9 lines, -5 lines 0 comments Download
M Source/web/WebPluginContainerImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M Source/web/tests/FrameTestHelpers.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/tests/WebPluginContainerTest.cpp View 1 2 3 4 5 6 7 8 3 chunks +75 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
chrishtr
I will need to work more on testing, and not even sure how to do ...
5 years, 6 months ago (2015-06-01 23:08:32 UTC) #2
pdr.
LGTM We've all spent hours fighting with our untested plugin integration. Could you try to ...
5 years, 6 months ago (2015-06-02 01:13:41 UTC) #3
chrishtr
Generalized to work with slimming paint. This required putting the metadata on GraphicsContext, since we ...
5 years, 6 months ago (2015-06-04 17:25:59 UTC) #5
pdr.
LGTM Do we need the skia/ext include? It seems to be allowed but looks a ...
5 years, 6 months ago (2015-06-04 18:03:56 UTC) #6
chrishtr
Added a test!!! Also, this CL depends on https://codereview.chromium.org/1167063003.
5 years, 6 months ago (2015-06-05 18:39:33 UTC) #7
pdr.
lgtm
5 years, 6 months ago (2015-06-05 18:44:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164683007/180001
5 years, 6 months ago (2015-06-05 19:41:18 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 22:18:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #9 (id:180001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196606

Powered by Google App Engine
This is Rietveld 408576698