I will need to work more on testing, and not even sure how to do ...
4 years, 11 months ago
(2015-06-01 23:08:32 UTC)
#2
I will need to work more on testing, and not even sure how to do it yet. I'd
like to not block this patch on that.
pdr.
LGTM We've all spent hours fighting with our untested plugin integration. Could you try to ...
4 years, 11 months ago
(2015-06-02 01:13:41 UTC)
#3
LGTM
We've all spent hours fighting with our untested plugin integration. Could you
try to make a test for this?
chrishtr
Patchset #5 (id:80001) has been deleted
4 years, 11 months ago
(2015-06-04 17:00:14 UTC)
#4
Patchset #5 (id:80001) has been deleted
chrishtr
Generalized to work with slimming paint. This required putting the metadata on GraphicsContext, since we ...
4 years, 11 months ago
(2015-06-04 17:25:59 UTC)
#5
Generalized to work with slimming paint. This required putting the metadata on
GraphicsContext, since we need it to propagate into drawing recorders.
Note that crbug.conm/496728 means only the top-level PDF printing works anyway,
SP or non-SP.
I'm looking at testing now.
pdr.
LGTM Do we need the skia/ext include? It seems to be allowed but looks a ...
4 years, 11 months ago
(2015-06-04 18:03:56 UTC)
#6
LGTM
Do we need the skia/ext include? It seems to be allowed but looks a little
strange.
chrishtr
Added a test!!! Also, this CL depends on https://codereview.chromium.org/1167063003.
4 years, 11 months ago
(2015-06-05 18:39:33 UTC)
#7
Issue 1164683007: Copy SkMetaData before painting printed plugin contents.
(Closed)
Created 4 years, 11 months ago by chrishtr
Modified 4 years, 11 months ago
Reviewers: pdr.
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 0