LayoutTests/editing/selection/containsNode.html - Issue 1308663003: The node and allowPartialContainment arguments for Selection API should not be optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/editing/selection/containsNode.html

Issue 1308663003: The node and allowPartialContainment arguments for Selection API should not be optional (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/editing/selection/containsNode.html

diff --git a/LayoutTests/editing/selection/containsNode.html b/LayoutTests/editing/selection/containsNode.html

index 3c16b67eefb7a60e6b619cc1727a9ef08b91adb0..c3bf56d5f2450947c77a03ea51d25ac036af7989 100644

--- a/LayoutTests/editing/selection/containsNode.html

+++ b/LayoutTests/editing/selection/containsNode.html

@@ -33,8 +33,6 @@ r.setStart(span1, 1);

r.setEnd(span1, 2);

s.addRange(r);

-shouldBe('s.containsNode(null, false)', false);

philipj_slow 2015/08/31 14:48:21 Instead of removing these tests, they should check

tanay.c 2015/09/01 10:58:08 Done.

-shouldBe('s.containsNode(null, true)', false);

shouldBe('s.containsNode(testDiv, false)', false);

shouldBe('s.containsNode(testDiv, true)', true);

shouldBe('s.containsNode(span1, false)', false);

« no previous file with comments | « no previous file | LayoutTests/editing/selection/containsNode-expected.txt » ('j') | Source/core/editing/DOMSelection.cpp » ('J')