LayoutTests/editing/selection/containsNode.html - Issue 1308663003: The node and allowPartialContainment arguments for Selection API should not be optional

Side by Side Diff: LayoutTests/editing/selection/containsNode.html

Issue 1308663003: The node and allowPartialContainment arguments for Selection API should not be optional (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <html>	1 <html>

2 <body>	2 <body>

3 <div id="test"><span id="span1">foo<span id="span2">bar</span></span><span id="s pan3">baz</span></div>	3 <div id="test"><span id="span1">foo<span id="span2">bar</span></span><span id="s pan3">baz</span></div>

4 <div id="console"></div>	4 <div id="console"></div>

5 <script>	5 <script>

6 var s = window.getSelection();	6 var s = window.getSelection();

7 var testDiv = document.getElementById("test");	7 var testDiv = document.getElementById("test");

8 var span1 = document.getElementById("span1");	8 var span1 = document.getElementById("span1");

9 var span2 = document.getElementById("span2");	9 var span2 = document.getElementById("span2");

10 var span3 = document.getElementById("span3");	10 var span3 = document.getElementById("span3");

(...skipping 15 matching lines...) Expand all Loading...
26 if (window.testRunner)	26 if (window.testRunner)

27 testRunner.dumpAsText();	27 testRunner.dumpAsText();

28	28

29 var r = document.createRange();	29 var r = document.createRange();

30	30

31 // select span2	31 // select span2

32 r.setStart(span1, 1);	32 r.setStart(span1, 1);

33 r.setEnd(span1, 2);	33 r.setEnd(span1, 2);

34 s.addRange(r);	34 s.addRange(r);

35	35

36 shouldBe('s.containsNode(null, false)', false);
philipj_slow 2015/08/31 14:48:21 Instead of removing these tests, they should check Instead of removing these tests, they should check that this throws an exception instead. Try shouldThrow(...). tanay.c 2015/09/01 10:58:08 Done. Show quoted text On 2015/08/31 14:48:21, philipj wrote: > Instead of removing these tests, they should check that this throws an exception > instead. Try shouldThrow(...). Done.
37 shouldBe('s.containsNode(null, true)', false);

38 shouldBe('s.containsNode(testDiv, false)', false);	36 shouldBe('s.containsNode(testDiv, false)', false);

39 shouldBe('s.containsNode(testDiv, true)', true);	37 shouldBe('s.containsNode(testDiv, true)', true);

40 shouldBe('s.containsNode(span1, false)', false);	38 shouldBe('s.containsNode(span1, false)', false);

41 shouldBe('s.containsNode(span1, true)', true);	39 shouldBe('s.containsNode(span1, true)', true);

42 shouldBe('s.containsNode(span2.firstChild, false)', true);	40 shouldBe('s.containsNode(span2.firstChild, false)', true);

43 shouldBe('s.containsNode(span2.firstChild, true)', true);	41 shouldBe('s.containsNode(span2.firstChild, true)', true);

44 shouldBe('s.containsNode(span3.firstChild, false)', false);	42 shouldBe('s.containsNode(span3.firstChild, false)', false);

45 shouldBe('s.containsNode(span3.firstChild, true)', false);	43 shouldBe('s.containsNode(span3.firstChild, true)', false);

46 shouldBe('s.containsNode(document, false)', false);	44 shouldBe('s.containsNode(document, false)', false);

47 shouldBe('s.containsNode(document.body, true)', true);	45 shouldBe('s.containsNode(document.body, true)', true);

(...skipping 21 matching lines...) Expand all Loading...
69 s.addRange(r);	67 s.addRange(r);

70	68

71 shouldBe('s.containsNode(span2, false)', true);	69 shouldBe('s.containsNode(span2, false)', true);

72 shouldBe('s.containsNode(span2.firstChild, false)', true);	70 shouldBe('s.containsNode(span2.firstChild, false)', true);

73 shouldBe('s.containsNode(span3, false)', false);	71 shouldBe('s.containsNode(span3, false)', false);

74 shouldBe('s.containsNode(span3, true)', true);	72 shouldBe('s.containsNode(span3, true)', true);

75	73

76 </script>	74 </script>

77 </body>	75 </body>

78 </html>	76 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/selection/containsNode-expected.txt » ('j') | Source/core/editing/DOMSelection.cpp » ('J')