Assume crashed RenderWidgetHost to be invisible

content/browser/frame_host/render_frame_host_manager.cc

Index: content/browser/frame_host/render_frame_host_manager.cc
diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc
index 71ec817e8d78b47bf48cc58b0cf878138f5921cd..b76ec6548a49056c281f86bcc0a465c965b4f546 100644
--- a/content/browser/frame_host/render_frame_host_manager.cc
+++ b/content/browser/frame_host/render_frame_host_manager.cc
@@ -432,6 +432,16 @@ RenderFrameHostImpl* RenderFrameHostManager::Navigate(
       if (dest_render_frame_host->GetView())
         dest_render_frame_host->GetView()->Hide();
     } else {
+      if (dest_render_frame_host->GetView()) {
+        if (dest_render_frame_host->GetView()->IsShowing() ==

[no sievers, 2015/09/04 16:18:03]

Instead of the if-condition, does it work to put:

DCHECK(!dest_render_frame_host->GetView()->IsShowing()) << "Crashed hosts should
be set invisible.";
if (delegate_->IsHidden())
  dest_render_frame_host->GetView()->Hide();
else
  dest_render_frame_host->GetView()->Show();

[Jaekyun Seok (inactive), 2015/09/07 07:40:04]

I tested the DCHECK, and I realized that loading a page in a new tab also
reached there because dest_render_frame_host->IsRenderFrameLive() only checks if
the renderer is alive or not; it doesn't check if it was crashed or not.

So we can't add the DCHECK.

+            delegate_->IsHidden()) {
+          if (delegate_->IsHidden())
+            dest_render_frame_host->GetView()->Hide();
+          else
+            dest_render_frame_host->GetView()->Show();
+        }
+      }
+
       // TODO(nasko): This is a very ugly hack. The Chrome extensions process
       // manager still uses NotificationService and expects to see a
       // RenderViewHost changed notification after WebContents and