Assume crashed RenderWidgetHost to be invisible

content/browser/frame_host/render_frame_host_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_manager.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/command_line.h"
@@ skipping 414 matching lines @@
                         frame_tree_node_->IsMainFrame()))
       return nullptr;
 
     // Now that we've created a new renderer, be sure to hide it if it isn't
     // our primary one.  Otherwise, we might crash if we try to call Show()
     // on it later.
     if (dest_render_frame_host != render_frame_host_) {
       if (dest_render_frame_host->GetView())
         dest_render_frame_host->GetView()->Hide();
     } else {
+      if (dest_render_frame_host->GetView()) {
+        if (dest_render_frame_host->GetView()->IsShowing() ==

[no sievers, 2015/09/04 16:18:03]

Instead of the if-condition, does it work to put:

DCHECK(!dest_render_frame_host->GetView()->IsShowing()) << "Crashed hosts should
be set invisible.";
if (delegate_->IsHidden())
  dest_render_frame_host->GetView()->Hide();
else
  dest_render_frame_host->GetView()->Show();

[Jaekyun Seok (inactive), 2015/09/07 07:40:04]

I tested the DCHECK, and I realized that loading a page in a new tab also
reached there because dest_render_frame_host->IsRenderFrameLive() only checks if
the renderer is alive or not; it doesn't check if it was crashed or not.

So we can't add the DCHECK.

+            delegate_->IsHidden()) {
+          if (delegate_->IsHidden())
+            dest_render_frame_host->GetView()->Hide();
+          else
+            dest_render_frame_host->GetView()->Show();
+        }
+      }
+
       // TODO(nasko): This is a very ugly hack. The Chrome extensions process
       // manager still uses NotificationService and expects to see a
       // RenderViewHost changed notification after WebContents and
       // RenderFrameHostManager are completely initialized. This should be
       // removed once the process manager moves away from NotificationService.
       // See https://crbug.com/462682.
       delegate_->NotifyMainFrameSwappedFromRenderManager(
           nullptr, render_frame_host_->render_view_host());
     }
   }
@@ skipping 2130 matching lines @@
 int RenderFrameHostManager::GetOpenerRoutingID(SiteInstance* instance) {
   if (!frame_tree_node_->opener())
     return MSG_ROUTING_NONE;
 
   return frame_tree_node_->opener()
       ->render_manager()
       ->GetRoutingIdForSiteInstance(instance);
 }
 
 }  // namespace content