Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1308553005: Remove a few IDL TODOs that have been fixed in the HTML spec (Closed)

Created:
5 years, 3 months ago by philipj_slow
Modified:
5 years, 3 months ago
Reviewers:
haraken, domenic
CC:
blink-reviews, Inactive, tyoshino+watch_chromium.org, vivekg_samsung, vivekg, yhirano+watch_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Remove a few IDL TODOs that have been fixed in the HTML spec BUG=460722 R=domenic@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201536

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M Source/core/frame/History.idl View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/modules/websockets/WebSocket.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
philipj_slow
5 years, 3 months ago (2015-08-31 14:15:06 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308553005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308553005/1
5 years, 3 months ago (2015-08-31 14:15:15 UTC) #3
domenic
lgtm
5 years, 3 months ago (2015-08-31 16:05:27 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-31 16:58:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308553005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308553005/1
5 years, 3 months ago (2015-09-01 08:34:06 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-01 08:34:08 UTC) #10
philipj_slow
haraken@, can you please rubberstamp and CQ this?
5 years, 3 months ago (2015-09-01 08:34:54 UTC) #12
haraken
LGTM
5 years, 3 months ago (2015-09-01 08:35:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308553005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308553005/1
5 years, 3 months ago (2015-09-01 08:35:47 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 08:40:09 UTC) #16
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201536

Powered by Google App Engine
This is Rietveld 408576698