Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Side by Side Diff: Source/core/frame/History.idl

Issue 1308553005: Remove a few IDL TODOs that have been fixed in the HTML spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/modules/websockets/WebSocket.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 12 matching lines...) Expand all
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 // https://html.spec.whatwg.org/#the-history-interface 26 // https://html.spec.whatwg.org/#the-history-interface
27 27
28 enum ScrollRestoration {"auto", "manual"}; 28 enum ScrollRestoration {"auto", "manual"};
29 29
30 [ 30 [
31 GarbageCollected, 31 GarbageCollected,
32 ] interface History { 32 ] interface History {
33 // TODO(philipj): length is long in the spec, use that or change the spec:
34 // https://www.w3.org/Bugs/Public/show_bug.cgi?id=28789
35 readonly attribute unsigned long length; 33 readonly attribute unsigned long length;
36 // TODO(philipj): The SerializedScriptValue type should be any. 34 // TODO(philipj): The SerializedScriptValue type should be any.
37 [CachedAttribute=stateChanged] readonly attribute SerializedScriptValue stat e; 35 [CachedAttribute=stateChanged] readonly attribute SerializedScriptValue stat e;
38 // TODO(philipj): delta does not have a default value in the spec:
39 // https://www.w3.org/Bugs/Public/show_bug.cgi?id=28790
40 [CallWith=ExecutionContext] void go(optional long delta = 0); 36 [CallWith=ExecutionContext] void go(optional long delta = 0);
41 [CallWith=ExecutionContext] void back(); 37 [CallWith=ExecutionContext] void back();
42 [CallWith=ExecutionContext] void forward(); 38 [CallWith=ExecutionContext] void forward();
43 // TODO(philipj): The SerializedScriptValue types should be any. 39 // TODO(philipj): The SerializedScriptValue types should be any.
44 // TODO(philipj): The title arguments should simply be 'DOMString title'. 40 // TODO(philipj): The title arguments should simply be 'DOMString title'.
45 [RaisesException] void pushState(SerializedScriptValue data, [TreatUndefined As=NullString] DOMString? title, optional DOMString? url = null); 41 [RaisesException] void pushState(SerializedScriptValue data, [TreatUndefined As=NullString] DOMString? title, optional DOMString? url = null);
46 [RaisesException] void replaceState(SerializedScriptValue data, [TreatUndefi nedAs=NullString] DOMString? title, optional DOMString? url = null); 42 [RaisesException] void replaceState(SerializedScriptValue data, [TreatUndefi nedAs=NullString] DOMString? title, optional DOMString? url = null);
47 43
48 // Experimental Scroll Restoration API 44 // Experimental Scroll Restoration API
49 // https://www.chromestatus.com/features/5657284784947200 45 // https://www.chromestatus.com/features/5657284784947200
50 [RuntimeEnabled=ScrollRestoration] attribute ScrollRestoration scrollRestora tion; 46 [RuntimeEnabled=ScrollRestoration] attribute ScrollRestoration scrollRestora tion;
51 }; 47 };
OLDNEW
« no previous file with comments | « no previous file | Source/modules/websockets/WebSocket.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698