Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 1308543007: Add placeholder files for talk/app/webrtc/mediacontroller.cc/.h to be able to update Chrome's libji… (Closed)

Created:
5 years, 3 months ago by the sun
Modified:
5 years, 3 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, kwiberg-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add placeholder files for talk/app/webrtc/mediacontroller.cc/.h to be able to update Chrome's libjingle.gyp before the MediaController implementation CL is submitted. BUG=webrtc:4690 Committed: https://crrev.com/7b38f6937087fed7011818a2692cd7f55c580813 Cr-Commit-Position: refs/heads/master@{#9872}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
A + talk/app/webrtc/mediacontroller.h View 2 chunks +3 lines, -7 lines 0 comments Download
A + talk/app/webrtc/mediacontroller.cc View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
the sun
5 years, 3 months ago (2015-09-03 15:08:14 UTC) #2
pthatcher1
lgtm
5 years, 3 months ago (2015-09-04 23:04:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308543007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308543007/20001
5 years, 3 months ago (2015-09-07 10:19:11 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-07 11:38:37 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 11:38:48 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b38f6937087fed7011818a2692cd7f55c580813
Cr-Commit-Position: refs/heads/master@{#9872}

Powered by Google App Engine
This is Rietveld 408576698